Queens is on Long Island. I used to live in Long Island City, Queens.
Queens (Queens County) and Brooklyn (Kings County) are both on Long Island. So are Nassau County, which attaches to Queesn on the west, and Suffolk, which is east of Nassau.
You can be "in" Queens while you are "on" Long Island.